Skip to content

Don't build bless_tests.patch #16224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2024
Merged

Don't build bless_tests.patch #16224

merged 1 commit into from
Oct 4, 2024

Conversation

cmb69
Copy link
Member

@cmb69 cmb69 commented Oct 4, 2024

The bless_tests.patch had been introduced via PR #7204, but is no longer available due to PR #11566. Since apparently the patch is not that helpful, we remove the code which generates it.

@cmb69
Don't build bless_tests.patch
ae12873 
The bless_tests.patch had been introduced via PR php#7204, but is no
longer available due to PR php#11566.  Since apparently the patch is not
that helpful, we remove the code which generates it.
@cmb69 cmb69 requested a review from TimWolla as a code owner October 4, 2024 15:14
iluuu1994
iluuu1994 approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@iluuu1994 iluuu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Since apparently the patch is not that helpful, we remove the code which generates it.

I'm not sure if we may not have had --show-diff set in the past? But nowadays it seems clear how exactly the output differs from the CI log.

@TimWolla TimWolla removed their request for review October 4, 2024 16:07
@cmb69 cmb69 merged commit bb3a3d0 into php:master Oct 4, 2024
10 checks passed
@cmb69 cmb69 deleted the cmb/bless-test branch October 4, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iluuu1994 iluuu1994 iluuu1994 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cmb69 @iluuu1994