-
Notifications
You must be signed in to change notification settings - Fork 8k
gen_stub: various simplifications and clean up #16291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
b70d1e6
gen_stub: remove unused `VariableLike::getVariableTypeCode()`
DanielEScherzer 813d8f4
gen_stub: remove unused `SimpleType::void()`
DanielEScherzer a9265be
gen_stub: inline single-use static SimpleType constructors
DanielEScherzer ed44c33
gen_stub: inline single-use `::setTypes()` methods
DanielEScherzer ab78bd3
gen_stub: inline single-use `VariableLike::addTypeToFieldSynopsis()` …
DanielEScherzer 3b39834
gen_stub: refactor `Type::tryToSimpleType()`, eliminate `::getWithout…
DanielEScherzer b7239d0
gen_stub: convert `ArgInfo::$sendBy` to a string
DanielEScherzer 7bb3b0d
gen_stub: make some methods only used within their class private
DanielEScherzer 262674f
gen_stub: stop cloning `ExposedDocComment` objects
DanielEScherzer d15d5f7
gen_stub: remove impossible `Type::__toString()` handling
DanielEScherzer 7dc17ed
gen_stub: document a bunch of properties as read-only
DanielEScherzer b6d3607
gen_stub: remove some misplaced spaces
DanielEScherzer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VariableLike::getTypeCode() should have called
getVariableTypeCode()
instead ofgetVariableTypeName()
, but since the difference is minimal, I'm fine the removal ofgetVariableTypeCode()
.