Skip to content

Remove special handling of exit/die in stubs #16308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2024
Merged

Remove special handling of exit/die in stubs #16308

merged 1 commit into from
Oct 9, 2024

Conversation

nikic
Copy link
Member

@nikic nikic commented Oct 8, 2024

PHP-Parser 5.3.1 allows these as function names to allow direct use in stubs.

@nikic
Remove special handling of exit/die in stubs
a2df083 
PHP-Parser 5.3.1 allows these as function names to allow direct
use in stubs.
@nikic nikic requested a review from Girgias October 8, 2024 18:55
@nikic nikic requested a review from kocsismate as a code owner October 8, 2024 18:55
@nikic nikic mentioned this pull request Oct 8, 2024
Closed
TimWolla
TimWolla reviewed Oct 8, 2024
View reviewed changes
Copy link
Member

@TimWolla TimWolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to target PHP-8.4, given that's the branch that introduced the workaround in the first place?

@nikic
Copy link
Member Author

nikic commented Oct 8, 2024

No strong opinion either way. It's a minor cleanup and does need a PHP-Parser upgrade, so I went with master.

Girgias
Girgias approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

I'm fine having this on master or PHP 8.4

@nikic nikic merged commit 517ac20 into php:master Oct 9, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TimWolla TimWolla TimWolla left review comments

@Girgias Girgias Girgias approved these changes

@kocsismate kocsismate Awaiting requested review from kocsismate kocsismate is a code owner

Assignees

No one assigned

Labels

Category: Build System

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nikic @TimWolla @Girgias