curl: Add curl_multi_get_handles()
#16363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimWolla
force-pushed
the
curl-multi-get-handles
branch
from
f0c466e to
a6bbd63
Compare
Girgias
reviewed
Oct 13, 2024
|
|
||
| array_init(return_value); | ||
| zend_llist_position pos; | ||
| zval *pz_ch; |
There was a problem hiding this comment.
The tab character seems unintentional here?
Suggested change
| zval *pz_ch; | |
| zval *pz_ch; |
There was a problem hiding this comment.
I've stolen the logic as-is from curl_multi_exec and did not adjust the code style to keep the file internally consistent. This also applies to the other remark.
There would be more to clean up here, for example the removal of the useless (zval *) cast, because a void* casts implicitly to anything.
Perhaps it would even make sense to migrate from zend_llist to HashTable.
There was a problem hiding this comment.
Sure, let's move this to a follow-up PR then.
| zend_llist_position pos; | ||
| zval *pz_ch; | ||
|
|
||
| for (pz_ch = (zval *)zend_llist_get_first_ex(&mh->easyh, &pos); pz_ch; |
There was a problem hiding this comment.
You could merge the declaration within the for loop.
Girgias
approved these changes
Oct 14, 2024
adoy
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://curl.se/libcurl/c/curl_multi_get_handles.html