Skip to content

Fix GH-16314 "Pdo\Mysql object is uninitialized" when opening a persistent connection #16369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2024
Merged

Fix GH-16314 "Pdo\Mysql object is uninitialized" when opening a persistent connection #16369

merged 1 commit into from
Nov 5, 2024

Conversation

kocsismate
Copy link
Member

@kocsismate kocsismate commented Oct 11, 2024 •
edited
Loading

Changes are made on top of #16167 because the two PRs touch the same code. Therefore only the last commit should be reviewed (c3f54df).

@kocsismate kocsismate changed the base branch from master to PHP-8.4 October 11, 2024 12:20
@cmb69 cmb69 linked an issue Oct 16, 2024 that may be closed by this pull request
"Pdo\Mysql object is uninitialized" when opening a persistent connection #16314
Closed
@kocsismate kocsismate force-pushed the fix-gh-16314 branch 2 times, most recently from de4d9b0 to 1a06371 Compare October 22, 2024 21:00
@kocsismate kocsismate merged commit a5f1378 into php:PHP-8.4 Nov 5, 2024
9 of 10 checks passed
kocsismate added a commit that referenced this pull request Nov 5, 2024
@kocsismate
Merge branch 'PHP-8.4'
a47d823 
* PHP-8.4:
  Fix GH-16314 "Pdo\Mysql object is uninitialized" when opening a persistent connection (#16369)
@iluuu1994
Copy link
Member

@kocsismate The new test ext/pdo_mysql/tests/gh16314.phpt fails in nightly. May you have a look?
https://github.com/php/php-src/actions/runs/11695572853/job/32571261655

@kocsismate kocsismate deleted the fix-gh-16314 branch November 6, 2024 10:37
@SakiTakamachi
Copy link
Member

I can fix it right away, so will fix it!

@SakiTakamachi SakiTakamachi mentioned this pull request Nov 6, 2024
Closed
@SakiTakamachi
Copy link
Member

Fixed

@iluuu1994
Copy link
Member

Thank you Saki!

@kocsismate
Copy link
Member Author

Thank you both! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SakiTakamachi SakiTakamachi Awaiting requested review from SakiTakamachi SakiTakamachi is a code owner

@devnexen devnexen Awaiting requested review from devnexen devnexen is a code owner

@NattyNarwhal NattyNarwhal Awaiting requested review from NattyNarwhal

Assignees

No one assigned

Labels

ABI break Extension: pdo (core) Extension: pdo_dblib Extension: pdo_firebird Extension: pdo_mysql Extension: pdo_odbc Extension: pdo_pgsql Extension: pdo_sqlite

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

"Pdo\Mysql object is uninitialized" when opening a persistent connection

3 participants

@kocsismate @iluuu1994 @SakiTakamachi