Skip to content

Mention where headers were already sent if session_start fails #16378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 15, 2024
Merged

Mention where headers were already sent if session_start fails #16378

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
30081d7
Mention where headers were already sent if session_start fails
NattyNarwhal Oct 11, 2024
e925c36
This should be a warning like before
NattyNarwhal Oct 14, 2024
fd6ca73
make clear this is where headers and not session were sent
NattyNarwhal Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion ext/session/session.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2644,7 +2644,14 @@ PHP_FUNCTION(session_start)
* module is unable to rewrite output.
*/
if (PS(use_cookies) && SG(headers_sent)) {
php_error_docref(NULL, E_WARNING, "Session cannot be started after headers have already been sent");
/* It's the header sent to blame, not the session in this case */
const char *output_start_filename = php_output_get_start_filename();
int output_start_lineno = php_output_get_start_lineno();
if (output_start_filename != NULL) {
php_error_docref(NULL, E_NOTICE, "Session cannot be started after headers have already been sent (started from %s on line %d)", output_start_filename, output_start_lineno);
} else {
php_error_docref(NULL, E_NOTICE, "Session cannot be started after headers have already been sent");
}
RETURN_FALSE;
}

Expand Down
19 changes: 19 additions & 0 deletions ext/session/tests/gh-16372.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
--TEST--
GH-16372: Mention where headers were already sent if session_start fails
--EXTENSIONS--
session
--SKIPIF--
<?php include('skipif.inc'); ?>
--FILE--
<?php

header("X-PHP-Test: test");

echo "Sent headers\n";

session_start();
?>
--EXPECTF--
Sent headers

Notice: session_start(): Session cannot be started after headers have already been sent (started from %s on line %d) in %s on line %d
Loading