Fix GH-16385: Unexpected null returned by session_set_cookie_params #16386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two issues: 1) The check happened before ZPP checks 2) The `return;` statement caused NULL to be returned while this function can only return booleans. An exception seems not acceptable in stable versions, but a warning may do.
Girgias
approved these changes
Oct 12, 2024
Comment on lines
+1680
to
+1683
| if (!PS(use_cookies)) { | ||
| php_error_docref(NULL, E_WARNING, "Session cookies cannot be used when session.use_cookies is disabled"); | ||
| RETURN_FALSE; | ||
| } |
There was a problem hiding this comment.
Should we even bother with an exception in master? Wasn't that INI setting deprecated in 8.4?
There was a problem hiding this comment.
No, for BC reasons this INI setting was left unaffected: https://wiki.php.net/rfc/deprecate-get-post-sessions#sessionuse_cookies_off
There was a problem hiding this comment.
The rest of the code for settings checks seems to use warnings, so if we change it we should be consistent. Maybe for now let's not
There was a problem hiding this comment.
AAAAAAAAAA okay, then it makes sense, but maybe it should be a more cohesive change to convert ext/session warnings to exceptions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two issues:
return;statement caused NULL to be returned while thisfunction can only return booleans. An exception seems not acceptable
in stable versions, but a warning may do.