Fix GH-16409: Segfault in exif_thumbnail when not dealing with a real file #16416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmb69
reviewed
Oct 13, 2024
ext/exif/tests/gh16409.phpt
Outdated
| exif | ||
| --SKIPIF-- | ||
| <?php | ||
| if (PHP_OS_FAMILY === "Windows") die("skip *nix only"); |
There was a problem hiding this comment.
Why? The test succeeds for me on Windows (ZTS).
There was a problem hiding this comment.
Didn't expect popen with echo to work on Windows, but to be honest I just assumed it and I didn't try it as I want to avoid Windows unless I really have to.
There was a problem hiding this comment.
My working test was actually:
<?php
$p = popen("echo 1", "r");
exif_thumbnail($p);:)
cmb69
approved these changes
Oct 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.