Skip to content

ext/session refactoring: INI settings #16419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

ext/session refactoring: INI settings #16419

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b60e2f7
Convert some Session globals from char* to zend_string*
Girgias Aug 12, 2022
7c04d83
Convert session_name from char to zend_string
Girgias Aug 12, 2022
b1c18ae
Use NUL spelling
Girgias Aug 19, 2022
3b213dd
address review comments
Girgias Aug 19, 2022
b03b233
Check for session name criterias consistently
Girgias Aug 19, 2022
b01aa3e
Use new API for checking if string has NUL bytes
Girgias Aug 22, 2022
aaa67ee
Use known length
Girgias Aug 30, 2022
0393e65
Rebase alignments
jorgsowa Oct 13, 2024
6660a1c
Improved error messages
jorgsowa Dec 6, 2024
d5de6ed
Replaced invalid OnUpdateString
jorgsowa Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions ext/session/php_session.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,14 +140,14 @@ typedef struct _php_session_rfc1867_progress {

typedef struct _php_ps_globals {
char *save_path;
char *session_name;
zend_string *session_name;
zend_string *id;
char *extern_referer_chk;
char *cache_limiter;
zend_string *extern_referer_chk;
zend_string *cache_limiter;
zend_long cookie_lifetime;
char *cookie_path;
char *cookie_domain;
char *cookie_samesite;
zend_string *cookie_path;
zend_string *cookie_domain;
zend_string *cookie_samesite;
bool cookie_secure;
bool cookie_httponly;
const ps_module *mod;
Expand Down Expand Up @@ -198,7 +198,7 @@ typedef struct _php_ps_globals {
bool rfc1867_enabled; /* session.upload_progress.enabled */
bool rfc1867_cleanup; /* session.upload_progress.cleanup */

bool use_strict_mode; /* whether or not PHP accepts unknown session ids */
bool use_strict_mode; /* whether PHP accepts unknown session ids */
bool lazy_write; /* omit session write when it is possible */
bool in_save_handler; /* state if session is in save handler or not */
bool set_handler; /* state if session module i setting handler or not */
Expand Down
Loading
Loading