Zend/tests: organize some tests with sub directories (2) #16423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @Girgias from the last patch |
Move more low-hanging fruit, creating new directories for the tests for * comparisons * dynamic calls * error messages * `error_reporting()` * exceptions * `foreach()` * garbage collection * group `use` statements * heredoc and nowdoc * `goto` jumps * late static binding * magic methods * namespaces * numeric literal separators * objects * oss-fuzz cases * `settype()` * cleaning of temporary values * `unset()` Additionally, move some tests into the existing sub directory for `list()` tests. Also fix some test numbers in the names of the `goto` tests. Work towards phpGH-15631
DanielEScherzer
force-pushed
the
test-org-2
branch
from
01fa783 to
ead3bad
Compare
|
|
I reverted that part, I can review those individually later |
|
I don't think this moving was a good idea ( |
|
@dstogov using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move more low-hanging fruit, creating new directories for the tests for
error_reporting()foreach()usestatementsgotojumpssettype()unset()Additionally, move some tests into the existing sub directory for
list()tests.Also fix some test numbers in the names of the
gototests.Work towards GH-15631