run-tests.php script: fix for options -l and -r failing #16519
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the options -l and -r for running single test files was failing with exception `PHP Fatal error: Uncaught ValueError: Path cannot be empty in run-tests.php:3926` for test files that exist.
iluuu1994
reviewed
Oct 20, 2024
There was a problem hiding this comment.
I don't understand the problem. Can you clarify what command exactly gives you this error? Note that -l and -r are supposed to be executed without specifying any files. The idea is to run the tests that failed in the last command.
An argument could be made that the list could be further filtered by specifying a directly or a list of files, but that's not currently how it is implemented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the options -l and -r for running single test files was failing with exception
PHP Fatal error: Uncaught ValueError: Path cannot be empty in run-tests.php:3926for test files that exist.