run-tests: removed unused code #16675
Conversation
| protected bool $version_3_8_0; | ||
| protected string $tool; | ||
|
|
||
| public function getHeader(): string |
There was a problem hiding this comment.
You sure?
Line 907 in 9d948c1
| $this->version_3_8_0 = version_compare($version, '3.8.0', '>='); | ||
| } | ||
|
|
||
| public function wrapCommand(string $cmd, string $memcheck_filename, bool $check_all): string |
There was a problem hiding this comment.
There was a problem hiding this comment.
Why do you think this if code can no longer be executed? Or how did you conclude this is never invoked?
There was a problem hiding this comment.
good catch!
phpstorm indicated the unused code. it seems it got tricked by the untyped global variables (and I got tricked by phpstorm ;)).
would you accept a new PR which gets rid of global variables in run-tests where possible?
There was a problem hiding this comment.
Maybe that's not worth it, it will make merging fixes in the test runner from lower to higher branches a bit harder, for no obvious benefit imho.
There was a problem hiding this comment.
I see. proposed something in #16678 - feel free to close it if you don't think its valuable
| /** | ||
| * @return bool|int | ||
| */ | ||
| function comp_line(string $l1, string $l2, bool $is_reg) |
There was a problem hiding this comment.
never called function
| protected bool $version_3_8_0; | ||
| protected string $tool; | ||
|
|
||
| public function getHeader(): string |
There was a problem hiding this comment.
You sure?
Line 907 in 9d948c1
| $this->version_3_8_0 = version_compare($version, '3.8.0', '>='); | ||
| } | ||
|
|
||
| public function wrapCommand(string $cmd, string $memcheck_filename, bool $check_all): string |
There was a problem hiding this comment.
Why do you think this if code can no longer be executed? Or how did you conclude this is never invoked?
staabm
force-pushed
the
run-tests-unused
branch
3 times, most recently
from
97c05d7 to
1c43015
Compare
2 participants
No description provided.