Fix GH-16665: \array and \callable should not be usable #16683
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This list was initially introduced in 53a4038, but never included array or callable. I suppose this is because int & friends are not actual tokens, while array and callable are. This means it was never possible to do class array, which is probably the reason this was overlooked.
|
What about other keywords like readonly, private, etc.? It's also not possible to create such classes. |
|
But those don't indicate types while array and callable do. |
mvorisek
reviewed
Nov 3, 2024
Comment on lines
+217
to
+218
| /* These are not usable as class names because they're proper tokens, | ||
| * but they are here for class aliases. */ |
There was a problem hiding this comment.
What about list, while, ..?
There was a problem hiding this comment.
See my comment #16683 (comment)
dstogov
approved these changes
Nov 6, 2024
iluuu1994
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This list was initially introduced in 53a4038, but never included array or callable. I suppose this is because int & friends are not actual tokens, while array and callable are. This means it was never possible to do class array, which is probably the reason this was overlooked.