Skip to content

Fixed GH-16262: Fixed a bug where size_t underflows #16696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fixed GH-16262: Fixed a bug where size_t underflows #16696

wants to merge 1 commit into from

Conversation

SakiTakamachi
Copy link
Member

Fixes #16262

There were cases where size_t underflowed because the variable that should have been specified was incorrect.

nielsdos
nielsdos approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems right, thanks!

SakiTakamachi added a commit that referenced this pull request Nov 4, 2024
@SakiTakamachi
Merge branch 'PHP-8.4'
f464298 
* PHP-8.4:
  Fixed a bug where size_t underflows (#16696)
  Added early return case when result is 0 (#16697)
@SakiTakamachi SakiTakamachi deleted the fix/gh16262 branch November 29, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nielsdos nielsdos nielsdos approved these changes

@Girgias Girgias Awaiting requested review from Girgias Girgias is a code owner

Assignees

No one assigned

Labels

Extension: bcmath

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SakiTakamachi @nielsdos