Skip to content

Conversation

SakiTakamachi
Copy link
Member

@SakiTakamachi SakiTakamachi commented Nov 5, 2024

Opened the PR :)
@nielsdos @cmb69

@SakiTakamachi SakiTakamachi changed the base branch from master to PHP-8.2 November 5, 2024 11:26
@SakiTakamachi SakiTakamachi marked this pull request as ready for review November 5, 2024 11:29
@SakiTakamachi
Copy link
Member Author

CI is red, I'll fix it

@SakiTakamachi
Copy link
Member Author

CI is green!

Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This looks good to me.

@SakiTakamachi
Copy link
Member Author

Thanks, maybe RMs seems to be working on packaging now, so I'll merge it tomorrow :)

Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

SakiTakamachi added a commit that referenced this pull request Nov 6, 2024
* PHP-8.2:
  Added gc_handler to properly handle circular references. (#16703)
SakiTakamachi added a commit that referenced this pull request Nov 6, 2024
* PHP-8.3:
  Added gc_handler to properly handle circular references. (#16703)
SakiTakamachi added a commit that referenced this pull request Nov 6, 2024
* PHP-8.4:
  Added gc_handler to properly handle circular references. (#16703)
@SakiTakamachi SakiTakamachi deleted the fix/pdo_memory_leak branch November 6, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants