Skip to content

Conversation

cmb69
Copy link
Member

@cmb69 cmb69 commented Nov 6, 2024

This is already done by ldap_set_rebind_proc_error.phpt, but not by the other two affected tests.


Note that while ldap_set_rebind_proc_error.phpt has this check right, it, the check for the server being available is borked, because it mixes URI and hostname.

$uri = getenv("LDAP_TEST_URI") ?: 'ldap://localhost:389';

This is already done by ldap_set_rebind_proc_error.phpt, but not by the
other two affected tests.
Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense but why not PHP-8.2 ?

@cmb69 cmb69 closed this in d276ea5 Nov 7, 2024
@cmb69
Copy link
Member Author

cmb69 commented Nov 7, 2024

but why not PHP-8.2 ?

For no particular reason. Applied to PHP-8.2 and merged up.

@cmb69 cmb69 deleted the cmb/ldap_set_rebind_proc branch November 7, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants