Skip to content

Fix GH-16780: gzseek aborts on non seekable stream. #16786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: PHP-8.2
Choose a base branch
from
Draft

Fix GH-16780: gzseek aborts on non seekable stream. #16786

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion main/streams/streams.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1354,7 +1354,9 @@ PHPAPI int _php_stream_seek(php_stream *stream, zend_off_t offset, int whence)

switch(whence) {
case SEEK_CUR:
ZEND_ASSERT(stream->position >= 0);
if (UNEXPECTED(stream->position == -1)) {
goto fail;
}
if (UNEXPECTED(offset > ZEND_LONG_MAX - stream->position)) {
offset = ZEND_LONG_MAX;
} else {
Expand Down Expand Up @@ -1393,6 +1395,7 @@ PHPAPI int _php_stream_seek(php_stream *stream, zend_off_t offset, int whence)
return 0;
}

fail:
php_error_docref(NULL, E_WARNING, "Stream does not support seeking");

return -1;
Expand Down
Loading