Yield without value in reference generator should create notice #16876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bellangelo
commented
Nov 21, 2024
| @@ -0,0 +1,17 @@ | |||
| --TEST-- | |||
There was a problem hiding this comment.
I have added this extra test file but I am not sure if this needed since the return_from_by_ref_generator.phpt also tests the notice.
|
@Bellangelo PRs should be made against the lowest supported bugfix branch. Right now this is PHP-8 2. |
Thanks @nielsdos. I thought the lowest supported was PHP-8.0. My bad. |
|
Closing in favor of #16882 |
Bellangelo
deleted the
yield-without-value-in-reference-generator-function
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16761