Fixed phrasing of documentation in php.ini #16903
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
reviewed
Nov 24, 2024
Comment on lines
444
to
+449
| ; By default, PHP is set to take action on all errors, notices and warnings EXCEPT | ||
| ; those related to E_NOTICE, which together cover best practices and | ||
| ; recommended coding standards in PHP. For performance reasons, this is the | ||
| ; recommend error reporting setting. Your production server shouldn't be wasting | ||
| ; resources complaining about best practices and coding standards. That's what | ||
| ; development servers and development settings are for. | ||
| ; those related to E_NOTICE, which covers best practices and recommended coding | ||
| ; standards in PHP. For performance reasons, this is the recommended error | ||
| ; reporting setting. Your production server shouldn't be wasting resources | ||
| ; complaining about best practices and coding standards. That's what develoment | ||
| ; servers and development settings are for. |
There was a problem hiding this comment.
I'm not even sure that is the case any more, pretty sure since 8.0.0 it is all errors including E_NOTICE that are emitted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the removal of E_STRICT, there is now only one error level that PHP ignores by default. This means the text following "all errors, notices and warnings EXCEPT those related to E_NOTICE..." should be in the singular rather than the plural. I noticed too that the following sentence also said "recommend" instead of "recommended".