Skip to content

Fix GH-17039: PHP 8.4: Incorrect MIME content type #17044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix GH-17039: PHP 8.4: Incorrect MIME content type #17044

wants to merge 1 commit into from

Conversation

nielsdos
Copy link
Member

@nielsdos nielsdos commented Dec 4, 2024

Backports file/file@ad925d3

@nielsdos nielsdos linked an issue Dec 4, 2024 that may be closed by this pull request
PHP 8.4: Incorrect MIME content type #17039
Closed
Girgias
Girgias approved these changes Dec 6, 2024
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MSTM, although I'm not familiar with the process of updating ext/fileinfo

@nielsdos nielsdos closed this in f1b24da Dec 8, 2024
spaze referenced this pull request in spaze/michalspacek.cz Jan 21, 2025
@spaze
Use a real .zip file in the test as that's the file type the class is…
09b75cf 
… using the most often

The PHP source code started to be detected as application/javascript on PHP 8.4 either because bundled libmagic has been updated, or because the setup-php action uses its own or something.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Girgias Girgias Girgias approved these changes

Assignees

No one assigned

Labels

Extension: fileinfo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PHP 8.4: Incorrect MIME content type

2 participants

@nielsdos @Girgias