Skip to content

Avoid string duplications in sqlite drivers #17115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 18, 2024
Merged

Avoid string duplications in sqlite drivers #17115

merged 1 commit into from
Dec 18, 2024

Conversation

nielsdos
Copy link
Member

These string duplications are necessary to unregister the callback later. We can just keep using zend_string to avoid memory duplications.

@nielsdos
Avoid string duplications in sqlite drivers
27adee4 
These string duplications are necessary to unregister the callback
later. We can just keep using zend_string to avoid memory duplications.
cmb69
cmb69 approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@nielsdos nielsdos merged commit b2c891f into php:master Dec 18, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cmb69 cmb69 cmb69 approved these changes

@SakiTakamachi SakiTakamachi Awaiting requested review from SakiTakamachi SakiTakamachi is a code owner

Assignees

No one assigned

Labels

Extension: pdo_sqlite Extension: sqlite3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nielsdos @cmb69