Add observer temporary to dl'ed functions #17220
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnaud-lb
requested review from
bukka,
dstogov and
kocsismate
as code owners
arnaud-lb
requested review from
bwoebi
and removed request for
bukka,
dstogov and
kocsismate
dstogov
approved these changes
Dec 20, 2024
bwoebi
approved these changes
Dec 20, 2024
charmitro
pushed a commit
to wasix-org/php
that referenced
this pull request
Mar 13, 2025
When observer is enabled, we normally add an extra temporary to all functions, to store the previously observed frame. However, this is done in zend_observer_post_startup() so it doesn't happen to dl'ed() functions. One possible fix would be to move that from zend_observer_post_startup() to zend_register_functions(), but this would be too early: Observer may not be enabled when zend_register_functions() is called, and may still be enabled later. However, when zend_register_functions() is called at run-time (during dl()), we know definitively whether observer is enabled. Here I update zend_register_functions() to add a temporary to dl'ed() functions when observer is enabled. Fixes: phpGH-17211 Closes: phpGH-17220
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible fix for GH-17211.
See #17211 (comment).
When observer is enabled, we normally add an extra temporary to all functions, to store the previously observed frame. However, this is done in
zend_observer_post_startup()so it doesn't happen to dl'ed() functions.One possible fix would be to move that from
zend_observer_post_startup()tozend_register_functions(), but this would be too early: Observer may not be enabled whenzend_register_functions()is called, and may still be enabled later.However, when
zend_register_functions()is called at run-time (duringdl()), we know definitively whether observer is enabled.Here I update
zend_register_functions()to add a temporary to dl'ed() functions when observer is enabled.