Skip to content

SplFileObject::fwrite $length param nullable #17242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 22, 2024
Merged

SplFileObject::fwrite $length param nullable #17242

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b0fa0d
SplFileObject::fwrite $length param nullable
kamil-tekiela Dec 22, 2024
de73f43
Add UPGRADING entry
kamil-tekiela Dec 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions ext/spl/spl_directory.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2606,15 +2606,18 @@ PHP_METHOD(SplFileObject, fwrite)
char *str;
size_t str_len;
zend_long length = 0;
bool length_is_null = true;
ssize_t written;

if (zend_parse_parameters(ZEND_NUM_ARGS(), "s|l", &str, &str_len, &length) == FAILURE) {
RETURN_THROWS();
}
ZEND_PARSE_PARAMETERS_START(1, 2)
Z_PARAM_STRING(str, str_len)
Z_PARAM_OPTIONAL
Z_PARAM_LONG_OR_NULL(length, length_is_null)
ZEND_PARSE_PARAMETERS_END();

CHECK_SPL_FILE_OBJECT_IS_INITIALIZED(intern);

if (ZEND_NUM_ARGS() > 1) {
if (!length_is_null) {
if (length >= 0) {
str_len = MIN((size_t)length, str_len);
} else {
Expand Down
2 changes: 1 addition & 1 deletion ext/spl/spl_directory.stub.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ public function fpassthru(): int {}
public function fscanf(string $format, mixed &...$vars): array|int|null {}

/** @tentative-return-type */
public function fwrite(string $data, int $length = 0): int|false {}
public function fwrite(string $data, ?int $length = null): int|false {}

/** @tentative-return-type */
public function fstat(): array {}
Expand Down
4 changes: 2 additions & 2 deletions ext/spl/spl_directory_arginfo.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading