Make imagebmp_basic.phpt more resilient #17265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checking for the exact output of most image formats is brittle; even an otherwise change to some header field causes the output to change, even if the image would be visually identical. Checking for an (MD5) hash is even worse, since if the tests fails, we have no clue for what reason. Thus we compare the generated image against an pre-generated PNG, using a test helper which will output a simple image diff in case of test failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking for the exact output of most image formats is brittle; even an otherwise change to some header field causes the output to change, even if the image would be visually identical.
Checking for an (MD5) hash is even worse, since if the tests fails, we have no clue for what reason.
Thus we compare the generated image against an pre-generated PNG, using a test helper which will output a simple image diff in case of test failure.