Skip to content

Relax possible E_ERROR condition to an Error exception #17285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 27, 2024
Merged

Relax possible E_ERROR condition to an Error exception #17285

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8fdde69
Relax possible E_ERROR condition to an Error exception
nielsdos Dec 27, 2024
1068c03
correction
nielsdos Dec 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ext/spl/spl_directory.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1600,8 +1600,7 @@ PHP_METHOD(GlobIterator, count)
RETURN_LONG(php_glob_stream_get_count(intern->u.dir.dirp, NULL));
} else {
/* This can happen by abusing destructors. */
/* TODO: relax this from E_ERROR to an exception */
php_error_docref(NULL, E_ERROR, "GlobIterator lost glob state");
zend_throw_error(NULL, "GlobIterator lost glob state");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to improve the error message? Also can you add a test to trigger this.

}
}
/* }}} */
Expand Down
Loading