ext/pdo: Refactor function and class statement fetch modes to reduce memory requirements #17289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamil-tekiela
approved these changes
Jan 7, 2025
| /* Possible error message */ | ||
| efree(is_callable_error); | ||
| } | ||
| ZEND_ASSERT(is_callable_error == NULL); |
There was a problem hiding this comment.
Is this really necessary? Shouldn't zend_fcall_info_init report failure reliably?
There was a problem hiding this comment.
The point is that there shouldn't be an error message to free if zend_fcall_info_init has failed.
This just adds an assertion that this indeed can never be the case.
| } | ||
| return false; | ||
| } | ||
| zval_ptr_dtor(&retval_constructor_call); |
There was a problem hiding this comment.
Why this doesn't need the Z_ISUNDEF check anymore?
There was a problem hiding this comment.
IS_UNDEF only happens if there is an exception that is thrown by the constructor.
Actually the thing that is pointless is to check for FAILURE as the result of zend_call_function() as that can never happen as we are not in shutdown.
Girgias
force-pushed
the
pdo-fetch-func-refacto
branch
2 times, most recently
from
f02c205 to
68efca5
Compare
Girgias
force-pushed
the
pdo-fetch-func-refacto
branch
from
68efca5 to
e246ec0
Compare
Most of the fields on the struct are useless or can be handled differently
Girgias
force-pushed
the
pdo-fetch-func-refacto
branch
from
e246ec0 to
ad42595
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This union struct was using a huge amount of memory for no good reason.