Port fix for libgd bug 447 #17320
Merged
Port fix for libgd bug 447 #17320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That bug has been potentially exploitable[1], but the GD extension was not affected by that, because `gdImageBmpPtr()` is never called. Still it seems to be reasonable to port the fix; if only to keep bundled and external libgd synced. [1] <GHSA-hc3p-jvff-jfw5>
devnexen
reviewed
Jan 2, 2025
| */ | ||
| void * gdImageBmpPtr(gdImagePtr im, int *size, int compression) | ||
| { | ||
| void *rv; |
There was a problem hiding this comment.
nit: I guess you can initialise it here saving 2 lines but that s nothing.
There was a problem hiding this comment.
Yeah, but I like to stay as close to upstream as possible (I still haven't completely lost hope that at some point in time we can unbundle libgd). And there we have https://github.com/libgd/libgd/blob/77adfd27f776352e8095d98ef4902c28975d19af/src/gd_bmp.c#L88-L99
devnexen
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That bug has been potentially exploitable[1], but the GD extension was not affected by that, because
gdImageBmpPtr()is never called. Still it seems to be reasonable to port the fix; if only to keep bundled and external libgd synced.[1] GHSA-hc3p-jvff-jfw5