Internalize gdImageScale*() and gdImageRotate*() helpers (sync with upstream) #17336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is basically a port of the "Small code cleanup" commit[1]. [1] <libgd/libgd@e054be7>
These have been introduced as fix for bug 72337[1], while the same issue had a simpler fix for upstream[2], because the helper functions already were internal. [1] <https://bugs.php.net/72337> [2] <libgd/libgd@77309c4>
|
No ABI break here (but an API break). |
devnexen
approved these changes
Jan 3, 2025
|
Closed via f55d6cc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commit messages for details.
Obviously, this is a BC break, and as such should be mentioned in UPGRADING.INTERNALS, but it's long overdue for parity with external libgd.
Note that I wanted to sync a bit more in this file, but looks like some issues in gd.c should be addressed first.