Skip to content

Reorder defs and decls in gd module (sync with upstream) #17338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Reorder defs and decls in gd module (sync with upstream) #17338

wants to merge 1 commit into from

Conversation

cmb69
Copy link
Member

@cmb69 cmb69 commented Jan 3, 2025

This is a mere refactoring to have better diffs.

@cmb69
Reorder defs and decls in gd module (sync with upstream)
c50db36 
This is a mere refactoring to have better diffs.
@cmb69 cmb69 requested a review from devnexen as a code owner January 3, 2025 13:29
@cmb69 cmb69 marked this pull request as draft January 4, 2025 22:37
@cmb69
Copy link
Member Author

cmb69 commented Feb 4, 2025

I'm closing this, because:

  • there are merge-conflicts which would need to be resolved
  • it is likely better to tackle that piecemeal, so that the reordering is comprehensible, and to reduce the impact of future merge-conflicts (what would require to do this over a long time period)
  • maybe it's better not to reorder at all; in the worst case, upstream reorders, and we're completely hosed

@cmb69 cmb69 closed this Feb 4, 2025
@cmb69 cmb69 deleted the cmb/reorder-gd branch February 4, 2025 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devnexen devnexen Awaiting requested review from devnexen devnexen is a code owner

Assignees

No one assigned

Labels

ABI break Extension: gd

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@cmb69