Use zend_string for dom iterators #17339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
approved these changes
Jan 3, 2025
ext/dom/element.c
Outdated
Comment on lines
1248
to
1255
| if (uri && ZSTR_LEN(uri) > INT_MAX) { | ||
| zend_argument_value_error(1, "is too long"); | ||
| RETURN_THROWS(); | ||
| } |
There was a problem hiding this comment.
might make sense to define uri to the empty zend string instead of the ternary below?
ext/dom/php_dom.c
Outdated
| if (objmap->free_local) { | ||
| xmlFree(objmap->local); | ||
| if (objmap->release_local) { | ||
| zend_string_release((zend_string *) (objmap->local - XtOffsetOf(zend_string, val))); |
There was a problem hiding this comment.
Maybe add a helper for this, don't remember for what other extension we did this.
There was a problem hiding this comment.
Yeah, I'll add the one from ldap
nielsdos
force-pushed
the
dom-iteratorsimprove
branch
from
1ffd13d to
167da5a
Compare
Girgias
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.