Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 20 additions & 5 deletions ext/sockets/multicast.c
Original file line number Diff line number Diff line change
Expand Up @@ -159,8 +159,16 @@ mcast_req_fun: ;
php_sockaddr_storage group = {0};
socklen_t glen;

convert_to_array(arg4);
opt_ht = Z_ARRVAL_P(arg4);
if (Z_TYPE_P(arg4) != IS_ARRAY) {
if (UNEXPECTED(Z_TYPE_P(arg4) != IS_OBJECT)) {
zend_argument_type_error(4, "must be of type array when argument #3 ($option) is MCAST_LEAVE_GROUP, %s given", zend_zval_value_name(arg4));
return FAILURE;
} else {
opt_ht = Z_OBJPROP_P(arg4);
}
} else {
opt_ht = Z_ARRVAL_P(arg4);
}

if (php_get_address_from_array(opt_ht, "group", php_sock, &group,
&glen) == FAILURE) {
Expand Down Expand Up @@ -194,9 +202,16 @@ mcast_req_fun: ;
source = {0};
socklen_t glen,
slen;

convert_to_array(arg4);
opt_ht = Z_ARRVAL_P(arg4);
if (Z_TYPE_P(arg4) != IS_ARRAY) {
if (UNEXPECTED(Z_TYPE_P(arg4) != IS_OBJECT)) {
zend_argument_type_error(4, "must be of type array when argument #3 ($option) is MCAST_LEAVE_SOURCE_GROUP, %s given", zend_zval_value_name(arg4));
return FAILURE;
} else {
opt_ht = Z_OBJPROP_P(arg4);
}
} else {
opt_ht = Z_ARRVAL_P(arg4);
}

if (php_get_address_from_array(opt_ht, "group", php_sock, &group,
&glen) == FAILURE) {
Expand Down
36 changes: 36 additions & 0 deletions ext/sockets/tests/socket_set_option_mcast_error.phpt
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
--TEST--
Multicast error
--EXTENSIONS--
sockets
--SKIPIF--
<?php
if (PHP_OS == 'Darwin') die('skip Not for macOS');
?>
--FILE--
<?php
include __DIR__."/mcast_helpers.php.inc";
$domain = AF_INET;
$level = IPPROTO_IP;
$interface = "lo";
$mcastaddr = '224.0.0.23';
$sblock = "127.0.0.1";

$s = socket_create($domain, SOCK_DGRAM, SOL_UDP);
$b = socket_bind($s, '0.0.0.0', 0);
$iwanttoleavenow = true;

try {
socket_set_option($s, $level, MCAST_LEAVE_GROUP, $iwanttoleavenow);
} catch (\TypeError $e) {
echo $e->getMessage(), PHP_EOL;
}

try {
socket_set_option($s, $level, MCAST_LEAVE_SOURCE_GROUP, $iwanttoleavenow);
} catch (\TypeError $e) {
echo $e->getMessage();
}
?>
--EXPECT--
socket_set_option(): Argument #4 ($value) must be of type array when argument #3 ($option) is MCAST_LEAVE_GROUP, true given
socket_set_option(): Argument #4 ($value) must be of type array when argument #3 ($option) is MCAST_LEAVE_SOURCE_GROUP, true given
Loading