Skip to content

__PROPERTY__ does not work in all constant expression contexts #17378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

__PROPERTY__ does not work in all constant expression contexts #17378

wants to merge 1 commit into from

Conversation

iluuu1994
Copy link
Member

Fixes GH-17222

arnaud-lb
arnaud-lb approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@arnaud-lb arnaud-lb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Do you intend to refactor in master?

@iluuu1994
Copy link
Member Author

Do you intend to refactor in master?

I can, yes.

@iluuu1994 iluuu1994 closed this in 147e9c8 Jan 13, 2025
iluuu1994 added a commit to iluuu1994/php-src that referenced this pull request Jan 13, 2025
@iluuu1994
Store prop info name in CG(context) instead of prop info
cd63806 
The prop info is not always available, e.g. when compiling the default
value.

See phpGH-17378
@iluuu1994 iluuu1994 mentioned this pull request Jan 13, 2025
Closed
iluuu1994 added a commit that referenced this pull request Jan 14, 2025
@iluuu1994
Store prop info name in CG(context) instead of prop info
e95b298 
The prop info is not always available, e.g. when compiling the default
value.

See GH-17378
Closes GH-17464
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arnaud-lb arnaud-lb arnaud-lb approved these changes

Assignees

No one assigned

Labels

Category: Engine

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@iluuu1994 @arnaud-lb