Allow Throwable to be extended outside of Exception #17385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to php#17233 Allow `\Throwable` to be extended directly without causing a Fatal error. * **Zend/zend_exceptions.c** - Remove the restriction in `zend_implement_throwable` function that checks if a class implementing `\Throwable` extends `Exception` or `Error`. - Update the `zend_register_default_exception` function to register the `zend_ce_throwable` interface without the restriction. * **Zend/tests/bug_test.phpt** - Add a new test file to ensure that extending `\Throwable` directly works as expected. - Add a test case to check if a class can extend `\Throwable` directly without causing a Fatal error. - Add a test case to check if a class extending `\Throwable` directly can implement the required methods.
|
See #17233 (comment). This change cannot land without an RFC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #17233
Allow
\Throwableto be extended directly without causing a Fatal error.Zend/zend_exceptions.c
zend_implement_throwablefunction that checks if a class implementing\ThrowableextendsExceptionorError.zend_register_default_exceptionfunction to register thezend_ce_throwableinterface without the restriction.Zend/tests/bug_test.phpt
\Throwabledirectly works as expected.\Throwabledirectly without causing a Fatal error.\Throwabledirectly can implement the required methods.