Skip to content

ext/mysql: Don't mention errors for optional part of the test #17466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

ext/mysql: Don't mention errors for optional part of the test #17466

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions ext/mysqli/tests/mysqli_get_client_stats.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -922,14 +922,14 @@ if (!mysqli_query($link, "DROP TABLE IF EXISTS non_result_set_queries_test"))
if (!mysqli_query($link, "DROP TABLE IF EXISTS client_stats_test"))
printf("[c004] Cannot drop table, [%d] %s\n", mysqli_errno($link), mysqli_error($link));

if (!mysqli_query($link, "DROP DATABASE IF EXISTS mysqli_get_client_stats_"))
printf("[c005] Cannot drop table, [%d] %s\n", mysqli_errno($link), mysqli_error($link));
// These tests are optional if the database and server fail to create them;
// for example, if the user the tests run as are unprivileged. If we didn't
// run those before, then errors like no permissions here are spurious.
mysqli_query($link, "DROP DATABASE IF EXISTS mysqli_get_client_stats_");

if (!mysqli_query($link, "DROP DATABASE IF EXISTS mysqli_get_client_stats"))
printf("[c006] Cannot drop table, [%d] %s\n", mysqli_errno($link), mysqli_error($link));
mysqli_query($link, "DROP DATABASE IF EXISTS mysqli_get_client_stats");

if (!mysqli_query($link, "DROP SERVER IF EXISTS myself"))
printf("[c007] Cannot drop table, [%d] %s\n", mysqli_errno($link), mysqli_error($link));
mysqli_query($link, "DROP SERVER IF EXISTS myself");

mysqli_close($link);
?>
Expand Down
Loading