Skip to content

win32: switch handful of memmove over memcpy. #17508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2025
Merged

win32: switch handful of memmove over memcpy. #17508

merged 1 commit into from
Jan 18, 2025

Conversation

@devnexen
Copy link
Member

No description provided.

@devnexen devnexen marked this pull request as ready for review January 18, 2025 14:07
@devnexen devnexen requested a review from cmb69 January 18, 2025 14:07
cmb69
cmb69 approved these changes Jan 18, 2025
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The buffers apparently do not overlap, so no problem using memcpy().

@devnexen devnexen merged commit 252c0c9 into php:master Jan 18, 2025
10 checks passed
@devnexen devnexen deleted the win32_memmove_to_memcpy branch February 16, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cmb69 cmb69 cmb69 approved these changes

Assignees

No one assigned

Labels

ABI break

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@devnexen @cmb69