Remove always-true check in pdo_stmt.c #17535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`check_empty` is checked earlier up, so this variable is always true.
Girgias
approved these changes
Jan 21, 2025
| } | ||
| ZEND_ASSERT(retval == &tmp_val); | ||
| bool res = check_empty ? i_zend_is_true(retval) : Z_TYPE(tmp_val) != IS_NULL; | ||
| bool res = i_zend_is_true(retval); |
There was a problem hiding this comment.
Sorry for being confused as always, but where is it checked? What are the possible values for this parameter? For example, DOM checks 3 values https://github.com/php/php-src/blob/master/ext/dom/php_dom.c#L455
There was a problem hiding this comment.
A bit above you can see an if (!check_empty) which returns without reading the column.
There was a problem hiding this comment.
Facepalm. I was looking at row_prop_exists
There was a problem hiding this comment.
No worries. For props the value of 2 for check_empty means checking if the property name exists without looking at its value. For dimensions, check_empty is a boolean
kamil-tekiela
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check_emptyis checked earlier up, so this variable is always true.