Remove useless compiler options #17553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `/Fp` provides a path name for procompiled headers[1], but we don't use these. * `/FR` is used to generate .sbr files; these have been important long ago for Visual Studio support, but as of Visual Studio 2008 the IDE no longer uses .sbr files. * `/LD` is used to inform the *compiler* that it should build a DLL[3]; however, we build all DLLs with the *linker*. [1] <https://learn.microsoft.com/en-us/cpp/build/reference/fp-name-dot-pch-file> [2] <https://learn.microsoft.com/en-us/cpp/build/reference/fr-fr-create-dot-sbr-file> [3] <https://learn.microsoft.com/en-us/cpp/build/reference/md-mt-ld-use-run-time-library>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/Fpprovides a path name for procompiled headers[1], but we don't use these./FRis used to generate .sbr files; these have been important long ago for Visual Studio support, but as of Visual Studio 2008 the IDE no longer uses .sbr files./LDis used to inform the compiler that it should build a DLL[3]; however, we build all DLLs with the linker.[1] https://learn.microsoft.com/en-us/cpp/build/reference/fp-name-dot-pch-file
[2] https://learn.microsoft.com/en-us/cpp/build/reference/fr-fr-create-dot-sbr-file
[3] https://learn.microsoft.com/en-us/cpp/build/reference/md-mt-ld-use-run-time-library