Skip to content

ext/pdo: Fix zend_object std layout for _pdo_row_t #17606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 29, 2025
Merged

ext/pdo: Fix zend_object std layout for _pdo_row_t #17606

merged 1 commit into from
Jan 29, 2025

Conversation

@Girgias
Copy link
Member

@Girgias Girgias commented Jan 28, 2025

See GH-17598 for more details

@Girgias Girgias mentioned this pull request Jan 28, 2025
Open
16 tasks
@nielsdos
Copy link
Member

This also means you can relax code like pdo_row_t *row = ecalloc(1, sizeof(pdo_row_t)); to use zend_object_alloc which should be a tad faster.

@Girgias Girgias merged commit b667939 into php:master Jan 29, 2025
9 checks passed
@Girgias Girgias deleted the pdo-row-struct-layout branch January 29, 2025 12:50
Girgias added a commit to Girgias/php-src that referenced this pull request Jan 29, 2025
@Girgias
ext/pdo: Use zend_object_alloc() for allocating PDORows
1d93734 
Follow-up for phpGH-17606
@Girgias Girgias mentioned this pull request Jan 29, 2025
Merged
Girgias added a commit that referenced this pull request Jan 29, 2025
@Girgias
ext/pdo: Use zend_object_alloc() for allocating PDORows (#17621)
0537968 
Follow-up for GH-17606
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SakiTakamachi SakiTakamachi Awaiting requested review from SakiTakamachi SakiTakamachi is a code owner

Assignees

No one assigned

Labels

ABI break Extension: pdo (core)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Girgias @nielsdos