Fix snmp_session_error.phpt for 32bit machines #17611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For `$retries === PHP_INT_MAX` there is no exception on 32bit machines. To avoid splitting the tests, or even not running it on 32bit, we work around.
devnexen
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
$retries === PHP_INT_MAXthere is no exception on 32bit machines. To avoid splitting the tests, or even not running it on 32bit, we work around.Fails in nightlies: https://github.com/php/php-src/actions/runs/13001856123/job/36261956882 (apparently the Windows x64 job is the only 32bit job running SNMP tests).