ext/pdo: Rearrange struct to pack and group related fields together #17651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All bound related fields are now part of the same cache line
Girgias
force-pushed
the
pdo-stmt-pack-struct
branch
from
7e1a041 to
9ee935d
Compare
nielsdos
reviewed
Jan 31, 2025
There was a problem hiding this comment.
This shrinks the struct to 224 bytes on x64 Linux indeed.
I think it's better to swap database_object_handle and dbh as dbh is accessed more frequently together with the rest. Although of course the allocation is likely not aligned to a cache line boundary so it will not make much difference anyway
nielsdos
approved these changes
Feb 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All bound related fields are now part of the same cache line