Skip to content

Elevate Windows CI to /W3 (sans C4018/C4267) #17665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 14, 2025
Merged

Elevate Windows CI to /W3 (sans C4018/C4267) #17665

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05f23cf
Elevate Windows CI to /W3 (sans C4018/C4267)
cmb69 Feb 1, 2025
576f876
Add comments regarding the disabled warnings
cmb69 Feb 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/scripts/windows/build_task.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,11 @@ if "%THREAD_SAFE%" equ "0" set ADD_CONF=%ADD_CONF% --disable-zts
if "%INTRINSICS%" neq "" set ADD_CONF=%ADD_CONF% --enable-native-intrinsics=%INTRINSICS%
if "%ASAN%" equ "1" set ADD_CONF=%ADD_CONF% --enable-sanitizer --enable-debug-pack

set CFLAGS=/W2 /WX /w14013 /wd4146 /wd4244
rem C4018: comparison: signed/unsigned mismatch
rem C4146: unary minus operator applied to unsigned type
rem C4244: type conversion, possible loss of data
rem C4267: 'size_t' type conversion, possible loss of data
set CFLAGS=/W3 /WX /wd4018 /wd4146 /wd4244 /wd4267
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

short comments above what these "numbers" are would greatly improve the readability

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. But I'm not 100% sure that makes much sense. One still needs to know what /W3 implies, and as such might need to look up the warnings "all the time". In my opinion, gcc and clang handle this much better.


cmd /c configure.bat ^
--enable-snapshot-build ^
Expand Down