Skip to content

Conversation

@Girgias
Copy link
Member

@Girgias Girgias commented Feb 6, 2025

Saw this from the recent commit.

Also the one call to php_openssl_load_rand_file and php_openssl_write_rand_file do not check for the return value. Not sure if this is a problem or not?

@bukka
Copy link
Member

bukka commented Feb 6, 2025

Also the one call to php_openssl_load_rand_file and php_openssl_write_rand_file do not check for the return value. Not sure if this is a problem or not?

They should be checked and return early.

@Girgias Girgias merged commit 78714d0 into php:master Feb 6, 2025
9 checks passed
@Girgias Girgias deleted the openssl-zend-result branch February 6, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants