Skip to content

Conversation

@Girgias
Copy link
Member

@Girgias Girgias commented Feb 8, 2025

Most of the time this will end up as a zend_string in some way anyway, do it directly.

Most of the time this will end up as a zend_string in some way anyway, do it directly.
Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense, should avoid some copies.
Not that this is particularly hot code, but a welcome change nevertheless.

@Girgias Girgias merged commit 1331a61 into php:master Feb 8, 2025
9 checks passed
@Girgias Girgias deleted the pdo-strpprintf-usage branch February 8, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants