Minor improvements in sqlite3 extension #17751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simplifies the code and reduces memory usage.
These checks are always false because we're receiving a valid zend_object.
devnexen
reviewed
Feb 9, 2025
nielsdos
force-pushed
the
sqlite3-micro-opts
branch
from
d94bd2e to
5f1aa3f
Compare
Girgias
approved these changes
Feb 10, 2025
Comment on lines
65
to
68
| bool initialised; | ||
| sqlite3 *db; | ||
| php_sqlite3_func *funcs; | ||
| php_sqlite3_collation *collations; |
There was a problem hiding this comment.
Shouldn't you move this next to the exception field to back it? As there are going to be 7 bytes of padding, and then again a bunch of padding after the exception field.
There was a problem hiding this comment.
I didn't do it originally because it seemed better to keep db and initialised in the same cacheline, but I see now that I can just move exception up and it will result in the same struct size while keeping db and initialised together.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review commits one by one. This reduces memory usage, uses cheaper string functions, and cleans up the code a bit.