Skip to content

ext/openssl: Check that loading/writing to RANDFILE succeeds #17758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ext/openssl: Check that loading/writing to RANDFILE succeeds #17758

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions ext/openssl/openssl_backend_common.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1452,7 +1452,10 @@ EVP_PKEY *php_openssl_generate_private_key(struct php_x509_request * req)

int egdsocket, seeded;
char *randfile = php_openssl_conf_get_string(req->req_config, req->section_name, "RANDFILE");
php_openssl_load_rand_file(randfile, &egdsocket, &seeded);
if (php_openssl_load_rand_file(randfile, &egdsocket, &seeded) == FAILURE) {
php_error_docref(NULL, E_WARNING, "Failed to load RANDFILE");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no point for extra warning.

return NULL;
}

EVP_PKEY *key = NULL;
EVP_PKEY *params = NULL;
Expand Down Expand Up @@ -1543,7 +1546,9 @@ EVP_PKEY *php_openssl_generate_private_key(struct php_x509_request * req)
req->priv_key = key;

cleanup:
php_openssl_write_rand_file(randfile, egdsocket, seeded);
if (php_openssl_write_rand_file(randfile, egdsocket, seeded) == FAILURE) {
php_error_docref(NULL, E_WARNING, "Failed to write to RANDFILE");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

}
EVP_PKEY_free(params);
EVP_PKEY_CTX_free(ctx);
return key;
Expand Down
Loading