Skip to content

Fix GH-17839 Negative SSE + fractions results in wrong timestamp #17840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+34 −1
Closed

Fix GH-17839 Negative SSE + fractions results in wrong timestamp #17840

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ext/date/lib/timelib.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,11 @@ timelib_long timelib_date_to_int(timelib_time *d, int *error)

ts = d->sse;

// adjust negative sse with fractions
if (ts < 0 && d->us) {
ts = ts + 1;
}

if (ts < TIMELIB_LONG_MIN || ts > TIMELIB_LONG_MAX) {
if (error) {
*error = 1;
Expand All @@ -182,7 +187,7 @@ timelib_long timelib_date_to_int(timelib_time *d, int *error)
if (error) {
*error = 0;
}
return (timelib_long) d->sse;
return (timelib_long) ts;
}

void timelib_decimal_hour_to_hms(double h, int *hour, int *min, int *sec)
Expand Down
28 changes: 28 additions & 0 deletions ext/date/tests/gh17839.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
--TEST--
Bug GH-17839 Negative SSE + fractions results in wrong timestamp
--FILE--
<?php

$dt1 = new DateTime('@1.1');
$dt2 = new DateTime('@-1.1');
var_dump($dt1, $dt1->getTimestamp());
var_dump($dt2, $dt2->getTimestamp());
--EXPECTF--
object(DateTime)#%d (%d) {
["date"]=>
string(26) "1970-01-01 00:00:01.100000"
["timezone_type"]=>
int(1)
["timezone"]=>
string(6) "+00:00"
}
int(1)
object(DateTime)#%d (%d) {
["date"]=>
string(26) "1969-12-31 23:59:58.900000"
["timezone_type"]=>
int(1)
["timezone"]=>
string(6) "+00:00"
}
int(-1)
Loading