Skip to content

ext/standard: pathinfo() check flags argument validity. #17859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

ext/standard: pathinfo() check flags argument validity. #17859

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8aa7b9
ext/standard: pathinfo() check flags argument validity.
devnexen Feb 18, 2025
e66b5e6
forbids flags combinations.
devnexen Feb 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ext/standard/string.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1587,6 +1587,11 @@ PHP_FUNCTION(pathinfo)
Z_PARAM_LONG(opt)
ZEND_PARSE_PARAMETERS_END();

if (opt < PHP_PATHINFO_DIRNAME || opt > PHP_PATHINFO_ALL) {
zend_argument_value_error(2, "must be one of the PATHINFO_* constants");
RETURN_THROWS();
}

have_basename = (opt & PHP_PATHINFO_BASENAME);

array_init(&tmp);
Expand Down
13 changes: 13 additions & 0 deletions ext/standard/tests/strings/pathinfo.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,17 @@ var_dump(pathinfo(__FILE__, PATHINFO_FILENAME|PATHINFO_BASENAME));
var_dump(pathinfo(__FILE__, PATHINFO_DIRNAME|PATHINFO_EXTENSION));
var_dump(pathinfo(__FILE__, PATHINFO_DIRNAME|PATHINFO_BASENAME));

try {
pathinfo(__FILE__, PATHINFO_DIRNAME-1);
} catch (\ValueError $e) {
echo $e->getMessage(), PHP_EOL;
}
try {
pathinfo(__FILE__, PATHINFO_ALL+1);
} catch (\ValueError $e) {
echo $e->getMessage(), PHP_EOL;
}

echo "Done\n";
?>
--EXPECTF--
Expand Down Expand Up @@ -102,4 +113,6 @@ string(%d) "%s%estrings"
string(12) "pathinfo.php"
string(%d) "%s%estrings"
string(%d) "%s%estrings"
pathinfo(): Argument #2 ($flags) must be one of the PATHINFO_* constants
pathinfo(): Argument #2 ($flags) must be one of the PATHINFO_* constants
Done
Loading