[RFC] Final Property Promotion #17861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
11 tasks
|
This does not appear to be explicitly specified in the RFC and is a language change. I'm not sure this is an appropriate bugfix for 8.4. |
|
/cc @Crell |
|
This came up, and there were some concerns it could imply const parameters as in Java. So we just left it out. |
|
So no, this is not a bug. If you think |
DanielEScherzer
force-pushed
the
final-promoted-props
branch
from
e3cee1b to
ad6d15a
Compare
DanielEScherzer
changed the title
final in constructor property promotion
mvorisek
reviewed
Apr 24, 2025
jorgsowa
reviewed
Jun 3, 2025
| public private(set) mixed $p7; | ||
| public private(set) final mixed $p8; | ||
|
|
||
| public function __construct( final $p9 ) {} |
There was a problem hiding this comment.
public function __construct( $p9 ) {}
It would be good to test also the case without the final property in the constructor.
DanielEScherzer
force-pushed
the
final-promoted-props
branch
from
ad6d15a to
6475a39
Compare
|
Any more reviewers? If not I'll probably merge this next week |
iluuu1994
approved these changes
Jun 21, 2025
There was a problem hiding this comment.
Only nits, the implementation looks correct. Thanks @DanielEScherzer!
TimWolla
approved these changes
Jun 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wiki.php.net/rfc/final_promotion