Skip to content

Fix memory leaks in pdo_sqlite callback registration #17904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix memory leaks in pdo_sqlite callback registration #17904

wants to merge 2 commits into from

Conversation

@nielsdos
Copy link
Member

  • We need to clean the trampoline if the construction check fails
  • Checking for an exception and then returning causes a leak on collation. Returning early is pointless anyway.

@nielsdos
Fix memory leaks in pdo_sqlite callback registration
938bbb8 
* We need to clean the trampoline if the construction check fails
* Checking for an exception and then returning causes a leak on
  `collation`. Returning early is pointless anyway.
Girgias
Girgias approved these changes Feb 23, 2025
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Are the other callback functions affected?

@nielsdos
Copy link
Member Author

Hm looks like pdo_sqlite_create_aggregate_internal has the same issue for the construct check actually, hang on

@nielsdos nielsdos closed this in 635fe26 Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Girgias Girgias Girgias approved these changes

@SakiTakamachi SakiTakamachi Awaiting requested review from SakiTakamachi SakiTakamachi is a code owner

Assignees

No one assigned

Labels

Extension: pdo_sqlite

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nielsdos @Girgias