Skip to content

ext/bcmath: Fixed pointer subtraction for scale #17986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

ext/bcmath: Fixed pointer subtraction for scale #17986

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c7baa98
The left and right of the ptr subtraction were reversed, so corrected…
SakiTakamachi Mar 7, 2025
a190da0
use c-style comment
SakiTakamachi Mar 7, 2025
12c3a4f
[skip ci] NEWS
SakiTakamachi Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ext/bcmath/libbcmath/src/str2num.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ bool bc_str2num(bc_num *num, const char *str, const char *end, size_t scale, siz
*/
if (str_scale > 0) {
const char *fractional_new_end = bc_skip_zero_reverse(fractional_end, fractional_ptr);
str_scale -= fractional_new_end - fractional_end;
str_scale -= fractional_end - fractional_new_end; // fractional_end >= fractional_new_end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use c-style comments, i.e. /* */

}
}
} else {
Expand Down
Loading